Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: jump menus #533

Merged
merged 6 commits into from
Aug 7, 2024
Merged

feature: jump menus #533

merged 6 commits into from
Aug 7, 2024

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Supports https://github.com/nasa-jpl/www/issues/172

Adds a new NavJumpMenu component that is based on NavSecondary. Also adds options to NavSecondary to support the style requirements of Secondary Nav 2.0 (see designs and written description)

Instructions to test

  1. make vue-storybook
  2. View the jump menu story: http://localhost:6006/?path=/story/navigation-jump-menu--base-story&globals=theme:ThemeEdu
  3. View the jump menu in a page template: http://localhost:6006/iframe.html?args=&globals=theme:ThemeEdu&id=templates-edu-pageedunewsdetail--base-story#/

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added patch Contains bug fixes or maintenance work feature labels Aug 7, 2024
@stephiescastle
Copy link
Member Author

Note: canceled storybook actions as they already passed and I didn't want to use our Percy quota

Copy link
Member

@jamesray jamesray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@stephiescastle stephiescastle merged commit e143636 into main Aug 7, 2024
2 of 6 checks passed
@stephiescastle stephiescastle deleted the feature/172-jump-menus branch August 7, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants